WEBDEV-7479 Tile updates for TV collections/clips #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
latonv
commented
May 23, 2025
latonv
force-pushed
the
webdev7479-tv-collection-tile
branch
from
2161af2 to
fb43b1f
Compare
bfalling
reviewed
Jun 18, 2025
bfalling
reviewed
Jun 18, 2025
|
Left a couple questions. No showstoppers found. LGTM. |
jbuckner
reviewed
Jun 18, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
==========================================
+ Coverage 92.63% 92.69% +0.05%
==========================================
Files 108 109 +1
Lines 17303 17488 +185
Branches 1355 1369 +14
==========================================
+ Hits 16029 16210 +181
- Misses 1214 1215 +1
- Partials 60 63 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
latonv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor tile changes are required to display results within TV collections, which may be "clips" of a larger program. Tiles in these collections should also display how many times they have been "clipped" in place of their review count.
We also need slight adjustments to the data source class and main component to recognize TV collections and set the correct state when they are encountered.